Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: VolumeRendererOp and VolumeLoaderOp updates #304

Merged
merged 2 commits into from
May 7, 2024

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented May 6, 2024

Update VolumeRendererOp and consuming app documentation to provide an overview and details for the ClaraViz JSON configuration file approach, including how to create a config file for new datasets.

Update VolumeLoaderOp documentation to indicate that only detached-header volume formats are currently supported.

Note: we plan to eventually expand upstream API documentation in ClaraViz to reflect config parameter settings. In the meantime we've pointed at ClaraViz gRPC sources with inline comments to help understand what each configuration field means. (thank you @AndreasHeumann )

Closes #302
Supports discussion in #301
Supports discussion in NVIDIA/clara-viz#47

Copy link
Contributor

@AndreasHeumann AndreasHeumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

tbirdso and others added 2 commits May 7, 2024 10:50
Update `VolumeRendererOp` and consuming app documentation to provide an
overview and details for the ClaraViz JSON configuration file approach,
including how to create a config file for new datasets.

co-authored-by: Andreas Heumann <[email protected]>
Signed-off-by: Tom Birdsong <[email protected]>
Update `VolumeLoaderOp` documentation to indicate that only
detached-header volume formats are currently supported.

co-authored-by: Andreas Heumann <[email protected]>
Signed-off-by: Tom Birdsong <[email protected]>
@tbirdso tbirdso force-pushed the volume_loader_formats_Doc branch from 78274c9 to 4fbb5c5 Compare May 7, 2024 14:50
@tbirdso
Copy link
Contributor Author

tbirdso commented May 7, 2024

Rebased on github/main and resolved README conflicts.

@tbirdso tbirdso merged commit bdf1382 into nvidia-holoscan:main May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume_loader configuration file documentation updates
3 participants