Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to latest @nuxt/module-builder #516

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: update to latest @nuxt/module-builder #516

merged 1 commit into from
Sep 9, 2024

Conversation

ThibaultVlacich
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

(from @danielroe)

Previous versions of @nuxt/module-builder produced incorrect types for files in the runtime/ directory. Specifically, a .d.ts declaration paired with a .mjs file. This isn't correct - it should be either .d.mts and .mjs or .d.ts and .js.

For maximum compatibility, @nuxt/module-builder v0.8 switched to .js extension for files in runtime/ directory.

With the latest Nuxt, this is now an error that removes correct plugin injection types.

Related PRs: nuxt/nuxt#28480, nuxt/nuxt#28593
See also nuxt/nuxt#28672.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 8:35am

@danielroe
Copy link
Contributor

It's less important for this module as it doesn't add a plugin so won't cause the linked issue, but should improve the types of the runtime directory.

@Baroshem
Copy link
Collaborator

Baroshem commented Sep 9, 2024

Hey @ThibaultVlacich thanks for this PR, could you please create it for the upcoming 2.0.0 branch as we want to release a new version with this change :)

@ThibaultVlacich ThibaultVlacich changed the base branch from main to chore/2.0.0 September 9, 2024 08:31
@ThibaultVlacich
Copy link
Contributor Author

Hey @ThibaultVlacich thanks for this PR, could you please create it for the upcoming 2.0.0 branch as we want to release a new version with this change :)

Done, I have rebased the PR :)

@Baroshem Baroshem merged commit a359071 into nuxt-modules:chore/2.0.0 Sep 9, 2024
3 checks passed
@Baroshem
Copy link
Collaborator

Baroshem commented Sep 9, 2024

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants