feat: support using regular expressions as CORS origin #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Sthamer <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Pascal Sthamer <[email protected]>
Signed-off-by: Pascal Sthamer <[email protected]>
Signed-off-by: Pascal Sthamer <[email protected]>
Signed-off-by: Pascal Sthamer <[email protected]>
P4sca1
changed the title
P4sca1
changed the title
Signed-off-by: Pascal Sthamer <[email protected]>
|
Looks great to me, @vejja what are your thoughts on that? Could we make it for the 2.0.0 release? Or should we reschedule it to 2.1.0? :) |
|
@Baroshem Are there any news? Would be great if this could be merged and a new RC release gets drafted. |
|
@vejja looking for your feedback :) |
|
LGTM, sorry for delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Changes CORS options type to only allow serializable values. Add a new
useRegExpproperty, that when set to true parses all origin values to a RegExp.Checklist: