Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sri: fetch buffers from storage and convert to object #396

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented Mar 6, 2024

Fixes #395

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Subresource Integrity for SSR is broken when using Nuxt 3.9+
This is related to the way Nuxt 3.9+ bundles strings, which is now using Uint8Array buffers.

This PR fixes this issue by:
1- correctly fetching SRI hashes in Uint8Array format
2- upgrading the module dependency to Nuxt 3.10

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview Mar 6, 2024 2:50pm

@vejja vejja self-assigned this Mar 6, 2024
@Baroshem Baroshem changed the base branch from main to chore/1.3.0 March 9, 2024 12:09
@Baroshem Baroshem merged commit 6e01494 into chore/1.3.0 Mar 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subresource Integrity error
2 participants