feat(csp): hashStyles option #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Baroshem
reviewed
Nov 3, 2023
src/types/index.ts
Outdated
| @@ -6,6 +6,7 @@ import type { AllowedHTTPMethods, BasicAuth, CorsOptions, RateLimiter, RequestSi | |||
|
|
|||
| export type Ssg = { | |||
| hashScripts?: boolean; | |||
| hashStyles?: boolean; | |||
There was a problem hiding this comment.
suggestion: Could you also please add it to the configuration documentation page where the default config is displayed?
|
@vejja could you please add the recommendations I mentioned? I would love to merge this PR now so that we can plan to release it with the next RC version :) |
|
Hey @Baroshem : isn't it covered in the CSP section now ? |
|
Let me know if this looks ok? |
Baroshem
approved these changes
Nov 9, 2023
|
Nice work, thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A user must be able to skip adding hashes to the 'style-src' policy
This is because adding even one hash cancels 'unsafe-inline'
Note: this is only for SSG
Description
Checklist: