move discovery VP validation to background process to prevent errors #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blocking the LC count\nadded background revocation check
gerardsn
approved these changes
Oct 16, 2024
discovery/store.go
Outdated
| @@ -410,7 +479,7 @@ func (s *sqlStore) setPresentationRefreshError(serviceID string, subjectID strin | |||
| } | |||
|
|
|||
| if refreshErr == nil { | |||
| // a delete | |||
| // a deletePresentationRecord | |||
woutslakhorst
deleted the
feature/3468_discovery_background_validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3468
any did:web or revocation downtime will not block discovery entries. Entries are invalid until VerifyVP succeeds at least once. After that a revocation checker will remove entries when a VC is revoked.
Only downside is a full table scan on presentation records every 10 minutes. If this becomes a problem (eg > 100k results) then
Searchhas to verify the VPs and delete entries as a side effect.... (or some elaborate eventing thing from revocationList to discovery service.)