Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introspection request returns error if missing a token #3465

Merged
merged 3 commits into from
Oct 8, 2024
Merged

introspection request returns error if missing a token #3465

merged 3 commits into from
Oct 8, 2024

Conversation

gerardsn
Copy link
Member

@gerardsn gerardsn commented Oct 8, 2024 •
edited
Loading

closes #3464

now returns a Warn message if there is no token (should only happen during development) and 415 if using the wrong content type

woutslakhorst
woutslakhorst requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not according to RFC7662. any wrong content (with the correct content-type) must result in a 200 with active set to false.

415 is allowed for the wrong content-type.

If more feedback is needed, check the logging.

@gerardsn gerardsn requested a review from woutslakhorst October 8, 2024 12:01
@gerardsn gerardsn merged commit b887163 into master Oct 8, 2024
9 checks passed
@gerardsn gerardsn deleted the fix-3464/require-token branch October 8, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

@reinkrul reinkrul Awaiting requested review from reinkrul reinkrul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

introspection returns no error when wrong media type is used
2 participants
@gerardsn @woutslakhorst