Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery: implement server API #2659

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Discovery: implement server API #2659

merged 3 commits into from
Dec 15, 2023

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Dec 8, 2023 •
edited
Loading

Implements APIs specified by RFC;

  • Register presentation
  • Delete presentation
  • Get presentations given tag (delta)

Out of scope: search (separate PR to keep changes small)

@reinkrul reinkrul force-pushed the discovery-api branch 3 times, most recently from 07f6081 to bf787a2 Compare December 11, 2023 13:43
@reinkrul reinkrul mentioned this pull request Dec 11, 2023
Merged
@reinkrul reinkrul marked this pull request as ready for review December 11, 2023 14:43
woutslakhorst
woutslakhorst previously requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok, but I think the error/status return for a wrong audience is incorrect. My guess is that it'll respond with a 500.

@reinkrul
Copy link
Member Author

All ok, but I think the error/status return for a wrong audience is incorrect. My guess is that it'll respond with a 500.

Internal server error? bad request qwould be more applicable?

gerardsn
gerardsn requested changes Dec 15, 2023
View reviewed changes
discovery/module.go Outdated Show resolved Hide resolved
discovery/api/v1/wapper.go Outdated Show resolved Hide resolved
@reinkrul reinkrul merged commit 27f2bb6 into master Dec 15, 2023
9 checks passed
@reinkrul reinkrul deleted the discovery-api branch December 15, 2023 14:08
rolandgroen added a commit to Headease/nuts-node that referenced this pull request Dec 18, 2023
@rolandgroen
Merge branch 'master' into mitzXnuts
9f3132a 
* master:
  complete s2s e2e test (nuts-foundation#2677)
  Cleanup unused file (nuts-foundation#2692)
  Discovery: implement server API (nuts-foundation#2659)
  VCR: Use JWT/JSON-LD constants from go-did (nuts-foundation#2691)
  Bump github/codeql-action from 2 to 3 (nuts-foundation#2687)
  split signature verification from verifier (nuts-foundation#2683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardsn gerardsn gerardsn approved these changes

@woutslakhorst woutslakhorst Awaiting requested review from woutslakhorst woutslakhorst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reinkrul @woutslakhorst @gerardsn