Postgres support #2638
Merged
Postgres support #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about the number of dependencies imported by dbmigrate? An alternative like https://github.com/pressly/goose does not have this problem.... |
|
or do we want #2648 (also adds mysql support) |
|
We probably want to rework this to have it rerun a set of tests (probably RFC021 test) on different databases |
woutslakhorst
force-pushed
the
postgres-support
branch
from
dfcce8f to
12ac8ed
Compare
woutslakhorst
force-pushed
the
postgres-support
branch
from
12ac8ed to
6c62ce7
Compare
|
@reinkrul should be working now |
woutslakhorst
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least have an e2e test to make sure the DDL statements are compatible. To be extended with tests for
did:web.We probably don't want unit tests for postgres, since spinning up Docker containers during
go testwill make stuff even slower than it already is.