add VDR v2 spec, generated code and empty wrapper #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
reviewed
Nov 29, 2023
| $ref: '#/components/schemas/DIDDocument' | ||
| default: | ||
| $ref: '../common/error_response.yaml' | ||
| /internal/vdr/v2/did/{did}: |
There was a problem hiding this comment.
this only resolves did:web DIDs owned by the local node? I think we already have /iam/{did} which essentially does the same?
There was a problem hiding this comment.
We have iam/{id}/did.json which is the public URL where the web DID Document lives.
We do not have a resolve API there. Since v1 might be removed v2 still needs a resolve.
|
Companion PR: #2631 |
|
Companion PR can be done in parallel. When implementing the Create on the v2 api, the method specifics on the v1 api can be removed. |
woutslakhorst
force-pushed
the
feature/2629/vdr_v2_api
branch
from
d952474 to
d6a2e0f
Compare
6 tasks
reinkrul
approved these changes
Dec 5, 2023
| @@ -1,7 +1,7 @@ | |||
| version: "3.7" | |||
| services: | |||
| nodeA-backend: | |||
| image: "${IMAGE_NODE_A:-nutsfoundation/nuts-node:master}" | |||
| image: "${IMAGE_NODE_A:-nutsfoundation/nuts-node:latest}" | |||
There was a problem hiding this comment.
Suggested change
| image: "${IMAGE_NODE_A:-nutsfoundation/nuts-node:latest}" | |
| image: "${IMAGE_NODE_A:-nutsfoundation/nuts-node:master}" |
| @@ -25,7 +25,7 @@ services: | |||
| - "../../tls-certs/truststore.pem:/etc/nginx/ssl/truststore.pem:ro" | |||
| - "./node-A/html:/etc/nginx/html:ro" | |||
| nodeB: | |||
| image: "${IMAGE_NODE_B:-nutsfoundation/nuts-node:master}" | |||
| image: "${IMAGE_NODE_B:-nutsfoundation/nuts-node:latest}" | |||
There was a problem hiding this comment.
Suggested change
| image: "${IMAGE_NODE_B:-nutsfoundation/nuts-node:latest}" | |
| image: "${IMAGE_NODE_B:-nutsfoundation/nuts-node:master}" |
|
Add to OpenAPI web epxlorer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2629
I described that removing a service does not have any influence on services referencing that service. Other than that everything is just basic CRUD.
One of those PRs where it takes more time to review than to make ;)