Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEX: Provide ParseEnvelope to correctly parse PEX VP envelopes #2620

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

reinkrul
Copy link
Member

Excerpt from #2518

@reinkrul reinkrul requested review from woutslakhorst and gerardsn and removed request for woutslakhorst November 24, 2023 16:20
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected more code removal due to envelope usage

vcr/pe/util.go Show resolved Hide resolved
vcr/pe/util.go Show resolved Hide resolved
vcr/pe/presentation_submission.go Outdated Show resolved Hide resolved
@reinkrul reinkrul merged commit 6211184 into master Nov 27, 2023
9 checks passed
@reinkrul reinkrul deleted the pex-parse-envelope branch November 27, 2023 13:39
woutslakhorst added a commit that referenced this pull request Dec 12, 2023
additional tests

additional test

PR feedback

PR feedback

test fix

remove failing test (#2618)

added e2e test for OpenID4VP s2s flow (#2617)

PEX: Provide ParseEnvelope to correctly parse PEX VP envelopes (#2620)

Bump schneider.vip/problem from 1.8.1 to 1.9.0 (#2622)

Bumps [schneider.vip/problem](https://github.com/mschneider82/problem) from 1.8.1 to 1.9.0.
- [Commits](mschneider82/problem@v1.8.1...v1.9.0)

---
updated-dependencies:
- dependency-name: schneider.vip/problem
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump golang.org/x/crypto from 0.15.0 to 0.16.0 (#2628)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0.
- [Commits](golang/crypto@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump golang.org/x/time from 0.4.0 to 0.5.0 (#2627)

Bumps [golang.org/x/time](https://github.com/golang/time) from 0.4.0 to 0.5.0.
- [Commits](golang/time@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Missing rfc021 e2e tests changes (#2623)

Discovery: SQLite-based server implementation (#2589)

Bump github.com/nuts-foundation/go-leia/v4 from 4.0.0 to 4.0.1 (#2632)

Bumps [github.com/nuts-foundation/go-leia/v4](https://github.com/nuts-foundation/go-leia) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/nuts-foundation/go-leia/releases)
- [Commits](nuts-foundation/go-leia@v4.0.0...v4.0.1)

---
updated-dependencies:
- dependency-name: github.com/nuts-foundation/go-leia/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Root URL server config property to replace auth.publicurl (#2633)

change idToDID to use did:web in iam API (#2635)

Bump github.com/lestrrat-go/jwx/v2 from 2.0.17 to 2.0.18 (#2645)

Bumps [github.com/lestrrat-go/jwx/v2](https://github.com/lestrrat-go/jwx) from 2.0.17 to 2.0.18.
- [Release notes](https://github.com/lestrrat-go/jwx/releases)
- [Changelog](https://github.com/lestrrat-go/jwx/blob/develop/v2/Changes)
- [Commits](lestrrat-go/jwx@v2.0.17...v2.0.18)

---
updated-dependencies:
- dependency-name: github.com/lestrrat-go/jwx/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump github.com/nats-io/nats-server/v2 from 2.10.5 to 2.10.6 (#2644)

Bumps [github.com/nats-io/nats-server/v2](https://github.com/nats-io/nats-server) from 2.10.5 to 2.10.6.
- [Release notes](https://github.com/nats-io/nats-server/releases)
- [Changelog](https://github.com/nats-io/nats-server/blob/main/.goreleaser.yml)
- [Commits](nats-io/nats-server@v2.10.5...v2.10.6)

---
updated-dependencies:
- dependency-name: github.com/nats-io/nats-server/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump alpine from 3.18.4 to 3.18.5 (#2636)

Bumps alpine from 3.18.4 to 3.18.5.

---
updated-dependencies:
- dependency-name: alpine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

more NO_CONTENT

timeout godoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants