Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEX: Allow VP format per submission wallet #2616

Closed
wants to merge 1 commit into from

Conversation

reinkrul
Copy link
Member

Each wallet potentially maps to a sign instruction, which each could have their own VP format.

Found this requirement when validating submissions with a list of VPs (requires rebuilding the presentation submission).

@reinkrul reinkrul requested review from woutslakhorst and gerardsn and removed request for woutslakhorst November 22, 2023 06:11
@woutslakhorst
Copy link
Member

The format is passed to fill a field in the mapping object. It should be determined by the VP format. This is defined by the client_metadata (verifier metadata) and must match the actual signing.

Does this mean that setting the format is actually some sort of post processing step? Or do we need to align client metadata with wallet capabilities before calling AddWallet?

@reinkrul
Copy link
Member Author

The format is passed to fill a field in the mapping object. It should be determined by the VP format. This is defined by the client_metadata (verifier metadata) and must match the actual signing.

Does this mean that setting the format is actually some sort of post processing step? Or do we need to align client metadata with wallet capabilities before calling AddWallet?

No, it is just use as instruction how to create the VP (jsonld/jwt). So the presentation signing function should take it into account.

But it doesn't solve the problem I stated; Resolve() and Validate() need to work on the PEX envelope (interface{}) instead

@reinkrul reinkrul closed this Nov 22, 2023
@reinkrul reinkrul deleted the pex-submission-format-per-wallet branch November 22, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants