add s2s access token request for relying party #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
force-pushed
the
feature/2504/vp_fo_s2s_flow
branch
from
bd5ec4b to
7d63ee8
Compare
woutslakhorst
force-pushed
the
feature/2504/vp_fo_s2s_flow
branch
from
7d63ee8 to
1cba83e
Compare
reinkrul
reviewed
Nov 6, 2023
| RequestRFC003AccessToken(ctx context.Context, jwtGrantToken string, authServerEndpoint url.URL) (*oauth.TokenResponse, error) | ||
|
|
||
| // RequestRFC021AccessToken is called by the local EHR node to request an access token from a remote Nuts node using Nuts RFC021. | ||
| RequestRFC021AccessToken(ctx context.Context, requestHolder did.DID, verifier did.DID, scopes string) (*oauth.TokenResponse, error) |
There was a problem hiding this comment.
not sure this is the right approach, given the variety of oauh2 and openID specs. But we need some moving around anyways, since the rest (OpenID4VP and VCI) is all over the place now
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
reinkrul
requested changes
Nov 6, 2023
reinkrul
requested changes
Nov 10, 2023
reinkrul
approved these changes
Nov 10, 2023
reinkrul
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2504
This PR implements the access token request and uses the clientAPI to request an actual access token.