Support secp256k1 and ed25519 keys #2564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
force-pushed
the
secp256k1-support
branch
2 times, most recently
from
99c4597 to
a18eace
Compare
reinkrul
force-pushed
the
secp256k1-support
branch
from
a18eace to
0ee4a22
Compare
reinkrul
force-pushed
the
secp256k1-support
branch
from
658f900 to
9bda90a
Compare
woutslakhorst
requested changes
Dec 15, 2023
|
|
||
| const ( | ||
| // ECP256Key is the key type for EC P-256 | ||
| ECP256Key KeyType = "secp256r1" |
There was a problem hiding this comment.
"official" name is P-256? What happened to 384 en 521?
| case ed25519.PrivateKey: | ||
| signer = k | ||
| if err != nil { | ||
| if err.Error() == "x509: failed to parse private key (use ParseECPrivateKey instead for this key format)" { |
There was a problem hiding this comment.
An error message could very well change with an update. Could you check against a error const or maybe always try to parse using parseECPrivateKey on failure?
| func parseECPrivateKey(block *pem.Block) (crypto.Signer, error) { | ||
| pk, err := x509.ParseECPrivateKey(block.Bytes) | ||
| if err != nil { | ||
| if err.Error() == "x509: unknown elliptic curve" { |
| See [the did core spec](https://www.w3.org/TR/did-core/#verification-method-types) for more information. | ||
| default: JsonWebKey2020 | ||
| enum: | ||
| - JsonWebKey2020 |
There was a problem hiding this comment.
Doesn't JsonWebKey2020 support all algo's?
There was a problem hiding this comment.
Pass key type but let proof format up to the impl?
| @@ -137,3 +144,20 @@ func buildDocument(subject did.DID, verificationMethods []did.VerificationMethod | |||
| } | |||
| return document | |||
| } | |||
|
|
|||
| func cryptoKeyType(verificationMethodType ssi.KeyType) (crypto.KeyType, error) { | |||
There was a problem hiding this comment.
This mapping is wrong. all secp EC keys and RSA keys can be expressed with JsonWebKey2020.
|
Can use changes from #2686 |
Merged
|
Too outdated, wrong and we now support ES256K in some form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: