Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEX: Validate Presentation Definitions and Submissions using JSON schema #2556

Merged
merged 6 commits into from
Oct 25, 2023
Merged

PEX: Validate Presentation Definitions and Submissions using JSON schema #2556

merged 6 commits into from
Oct 25, 2023

Conversation

reinkrul
Copy link
Member

Fixes #2554

gerardsn
gerardsn requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful addition. Tests on the schemas seem a bit minimal, but I don't know how much sense it makes to test the schemas that are supposed to do the testing.

go.mod Show resolved Hide resolved
vcr/pe/schema/v2/presentation-definition-claim-format-designations.json Show resolved Hide resolved
vcr/pe/schema/v2/schema.go Show resolved Hide resolved
vcr/pe/schema/gen/go.mod Outdated Show resolved Hide resolved
vcr/pe/schema/v2/schema.go Outdated Show resolved Hide resolved
@reinkrul
Copy link
Member Author

Tests on the schemas seem a bit minimal, but I don't know how much sense it makes to test the schemas that are supposed to do the testing.

Exactly, that's why I just added a small test, just to check whether it's actually functioning.

@reinkrul reinkrul requested a review from gerardsn October 23, 2023 10:25
gerardsn
gerardsn approved these changes Oct 23, 2023
View reviewed changes
vcr/pe/schema/v2/schema.go Show resolved Hide resolved
vcr/pe/schema/v2/schema.go Outdated Show resolved Hide resolved
vcr/pe/schema/v2/presentation-definition-claim-format-designations.json Show resolved Hide resolved
woutslakhorst
woutslakhorst reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was working on a PR for the SubmissionRequirements feature. Is there a JSON schema for that as well?

@reinkrul
Copy link
Member Author

reinkrul commented Oct 25, 2023 •
edited
Loading

I was working on a PR for the SubmissionRequirements feature. Is there a JSON schema for that as well?

Yes, see chapter 11: https://identity.foundation/presentation-exchange/#json-schemas or https://github.com/decentralized-identity/presentation-exchange/tree/main/schemas/v2.0.0

@woutslakhorst
Copy link
Member

I was working on a PR for the SubmissionRequirements feature. Is there a JSON schema for that as well?

Yes, see chapter 11: https://identity.foundation/presentation-exchange/#json-schemas or https://github.com/decentralized-identity/presentation-exchange/tree/main/schemas/v2.0.0

Could you include it please ... 🙇

@reinkrul reinkrul force-pushed the pex_schema_validation branch from bb71eaf to f33d387 Compare October 25, 2023 12:43
@reinkrul reinkrul merged commit c8abcf3 into master Oct 25, 2023
6 checks passed
@reinkrul reinkrul deleted the pex_schema_validation branch October 25, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst left review comments

@gerardsn gerardsn gerardsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate PEX definitions and submissions against JSON schema
3 participants
@reinkrul @woutslakhorst @gerardsn