Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIOPv2 flow with Sphereon Wallet #2526

Closed
wants to merge 1 commit into from
Closed

SIOPv2 flow with Sphereon Wallet #2526

wants to merge 1 commit into from

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Oct 4, 2023 •
edited
Loading

TODO:

  • Cleanup: find out what's JWT VC Presentation Profile v1, SIOPv2 ID1, etc
  • Determine what to do with did:key support (Sphereon Wallet presents an id_token signed with it), otherwise we can't verify the JWT
  • Cleanup: HTTP handlers are a mess now
  • Implement vp_token as well
  • Determine what to do with the OpenID4VP wallet demo-code we have right now (another system asking your node for credentials over OpenID4VP). I don't think we're going to use this, since then someone would use the Nuts node as personal wallet (which is weird)? So I think we can remove the code.

@reinkrul reinkrul changed the title Verify VC from Sphereon Wallet OpenDI4VP flow with Sphereon Wallet Oct 4, 2023
@reinkrul reinkrul force-pushed the openid4vp_wallet_demo branch 4 times, most recently from 62a76c1 to 24d36c3 Compare October 5, 2023 12:56
@reinkrul reinkrul changed the title OpenDI4VP flow with Sphereon Wallet SIOPv2 flow with Sphereon Wallet Oct 5, 2023
@reinkrul reinkrul force-pushed the openid4vp_wallet_demo branch 2 times, most recently from 990fe6b to 061f658 Compare October 6, 2023 13:55
@reinkrul reinkrul force-pushed the openid4vp_wallet_demo branch from 4a9550c to 7b164ad Compare October 26, 2023 08:08
@reinkrul
Copy link
Member Author

reinkrul commented Apr 5, 2024

Very stale now, will probably be reworked after DIIP v2 is out.

@reinkrul reinkrul closed this Apr 5, 2024
@reinkrul reinkrul deleted the openid4vp_wallet_demo branch April 5, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst Awaiting requested review from woutslakhorst woutslakhorst will be requested when the pull request is marked ready for review woutslakhorst is a code owner

@gerardsn gerardsn Awaiting requested review from gerardsn gerardsn will be requested when the pull request is marked ready for review gerardsn is a code owner

@stevenvegt stevenvegt Awaiting requested review from stevenvegt stevenvegt will be requested when the pull request is marked ready for review stevenvegt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reinkrul