IAM: Implement correct OAuth2 error handling #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
requested changes
Sep 27, 2023
| redirectURI, _ := url.Parse(oauthErr.RedirectURI) | ||
| if oauthErr.RedirectURI == "" || redirectURI == nil { | ||
| // Can't redirect the user-agent back, render error as JSON or plain text (depending on content-type) | ||
| contentType := echoContext.Request().Header.Get("Content-Type") |
There was a problem hiding this comment.
Content-Type or Accept header?
There was a problem hiding this comment.
At first, I had both. But that introduced unused code paths (Accept header being application/json), which adds complexity and no value. So given the assumption that a browser will never send application/json as content-type (maybe with a form post with enctype set to that value, but that would be very, very weird?), and API clients will use JSON, I just settles on Content-Type = application/json for now.
When proven otherwise in future, we can easily adapt this.
reinkrul
force-pushed
the
iam-oauth2-errors
branch
from
9d0b24e to
f5c6a30
Compare
|
Force-pushed after fixing conflicts a bit too early |
|
Suggestion applied. |
woutslakhorst
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an OAuth2 error handler that:
redirect_uri(witherroranderror_descriptionparameters)redirect_uri, it either prints the error as plain text (for a browser) or JSON (for an API client)It also fixes HTTP request logging status codes for the IAM API package.