feedback

nuts-foundation · Dec 15, 2023 · 6ee9fc5 · 6ee9fc5
1 parent b7ab286
commit 6ee9fc5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/discovery/api/v1/wapper.go → discovery/api/v1/wrapper.go b/discovery/api/v1/wapper.go → discovery/api/v1/wrapper.go
diff --git a/discovery/api/v1/wapper_test.go → discovery/api/v1/wrapper_test.go b/discovery/api/v1/wapper_test.go → discovery/api/v1/wrapper_test.go
diff --git a/discovery/module.go b/discovery/module.go
@@ -208,7 +208,7 @@ func (m *Module) validateRetraction(serviceID string, presentation vc.Verifiable
 	// If not, it might've already been removed due to expiry or superseded by a newer presentation.
 	retractJTIRaw, _ := presentation.JWT().Get("retract_jti")
 	retractJTI, ok := retractJTIRaw.(string)
-	if !ok {
+	if !ok || retractJTI == "" {
 		return errInvalidRetractionJTIClaim
 	}
 	signerDID, _ := credential.PresentationSigner(presentation) // checked before

diff --git a/discovery/module_test.go b/discovery/module_test.go
@@ -183,7 +183,7 @@ func Test_Module_Add(t *testing.T) {
 			err := m.Add(testServiceID, vp)
 			assert.ErrorIs(t, err, errInvalidRetractionJTIClaim)
 		})
-		t.Run("'retract_jti' claim in not a string", func(t *testing.T) {
+		t.Run("'retract_jti' claim is not a string", func(t *testing.T) {
 			m, _ := setupModule(t, storageEngine)
 			vp := createPresentationCustom(aliceDID, func(claims map[string]interface{}, vp *vc.VerifiablePresentation) {
 				vp.Type = append(vp.Type, retractionPresentationType)
@@ -193,6 +193,16 @@ func Test_Module_Add(t *testing.T) {
 			err := m.Add(testServiceID, vp)
 			assert.ErrorIs(t, err, errInvalidRetractionJTIClaim)
 		})
+		t.Run("'retract_jti' claim is an empty string", func(t *testing.T) {
+			m, _ := setupModule(t, storageEngine)
+			vp := createPresentationCustom(aliceDID, func(claims map[string]interface{}, vp *vc.VerifiablePresentation) {
+				vp.Type = append(vp.Type, retractionPresentationType)
+				claims["retract_jti"] = ""
+				claims[jwt.AudienceKey] = []string{testServiceID}
+			})
+			err := m.Add(testServiceID, vp)
+			assert.ErrorIs(t, err, errInvalidRetractionJTIClaim)
+		})
 	})
 }