Support matplotlib >=3.6.0 #1095
Open
+20
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whyekit-motional would you mind reviewing this PR? matplotlib 3.5.3 was released in Aug 2022 and it is the latest version supported by nuscenes-devkit. Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nuscene-devkitonly supports matplotlib < 3.6.0. I have tried to apply the suggestion from this comment and see if this works with matplotlib >= 3.4.0 (I'm mostlry interested in 3.6.0+ due to this issue)The change rename
fig.canvas.set_window_titletofig.canvas.manager.set_window_titleI still need to build a PR and test it.