Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Fixing nyc_taxi.csv #3748

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing nyc_taxi.csv #3748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a73bcd
Change nyc_taxi.csv to nycTaxi.csv
jlee124 Jul 21, 2017
081e051
Change nyc_taxi.csv to nycTaxi.csv and filenames
jlee124 Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/opf/clients/nyctaxi/nyctaxi_anomaly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,16 @@
_LOGGER = logging.getLogger(__name__)

_INPUT_DATA_FILE = resource_filename(
"nupic.datafiles", "extra/nyctaxi/nyc_taxi.csv"
"nupic.datafiles", "extra/nyctaxi/nycTaxi.csv"
)
_OUTPUT_PATH = "anomaly_scores.csv"

_ANOMALY_THRESHOLD = 0.9

# minimum metric value of nyc_taxi.csv
# minimum metric value of nycTaxi.csv
_INPUT_MIN = 8

# maximum metric value of nyc_taxi.csv
# maximum metric value of nycTaxi.csv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That standard was only for python source file names. I don't think we have a standard for data files. I'm happy as long as it works.

_INPUT_MAX = 39197


Expand Down
0 ...upic/datafiles/extra/nycTaxi/nyc_taxi.csv → ...nupic/datafiles/extra/nycTaxi/nycTaxi.csv
View file
Open in desktop
File renamed without changes.