Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed Integration tests for 'users' and 'home' controller #74

Merged
merged 19 commits into from
Mar 27, 2021
Merged

Completed Integration tests for 'users' and 'home' controller #74

merged 19 commits into from
Mar 27, 2021

Conversation

sunilkr
Copy link
Collaborator

@sunilkr sunilkr commented Mar 14, 2021 •
edited
Loading

#22

  • Updated doc\developer-guide-docker-compose.md to cover Docker Desktop with WSL2 backend on Windows 10.
  • Renamed users_test -> user_password_test to be consistent with controller. Other user paths are already covered in devise_registration_test, devise_login_test.
  • Added test for root path/home page.

sunilkr and others added 19 commits July 7, 2019 09:24
@sunilkr
Addes some tests for users profile
473e2b2
@sunilkr
Adding tp correct branch
b33a315
@sunilkr
Merge branch 'master' of https://github.com/null-open-security-commun…
4e91742 
…ity/swachalit
@sunilkr
Merge branch 'master' of https://github.com/null-open-security-commun…
ec902af 
…ity/swachalit
@sunilkr
Merge branch 'master' of https://github.com/null-open-security-commun…
2df2fe7 
…ity/swachalit
@sunilkr
Merge branch 'master' of https://github.com/null-open-security-commun…
441831b 
…ity/swachalit
@sunilkr
Merge branch 'master' of https://github.com/null-open-security-commun…
89681cc 
…ity/swachalit
@sunilkr
Added 2 tests to users. TODO: password change
f7f1a23
@sunilkr
corrected tests
43b8cdf
@sunilkr
Skipping password change tests as this is handled by devise.
ea1751f
@sunilkr
Merge branch 'master' of https://github.com/null-open-security-commun…
bb3509c 
…ity/swachalit
@sunilkr
fix for null-open-security-community#66 as suggested by @anantshri
39d8213
@abhisek
Merge branch 'master' into master
68d7b35
@sunilkr
changed padding unit to em
9676f1b
@sunilkr
Merge branch 'master' of https://github.com/sunilkr/swachalit
277d446
@sunilkr
Added notes for Docker Desktop on Windows
38d7c68
@sunilkr
Create users_password integration test
0e139d5
@sunilkr
Completed integration tests for home page
be630ec
@sunilkr
Merge branch 'master' of https://github.com/null-open-security-commun…
416af56 
…ity/swachalit
@sunilkr
Copy link
Collaborator Author

sunilkr commented Mar 14, 2021

@anantshri @abhisek please review.

abhisek
abhisek approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@abhisek abhisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for newly added integration tests

test/integration/users_test.rb
@@ -1,44 +0,0 @@
require 'test_helper'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunilkr Why are we deleting this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed users_test -> user_password_test to be consistent with controller. Other user paths are already covered in devise_registration_test, devise_login_test. Git didn't treat as file rename.

@sunilkr sunilkr requested a review from abhisek March 19, 2021 17:47
@abhisek abhisek merged commit 3f752de into null-open-security-community:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhisek abhisek Awaiting requested review from abhisek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunilkr @abhisek