Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add top announcement section #144

Merged
merged 1 commit into from
Dec 9, 2024
Merged

feat: Add top announcement section #144

merged 1 commit into from
Dec 9, 2024

Conversation

abhisek
Copy link
Member

@abhisek abhisek commented Dec 9, 2024

No description provided.

@anantshri
Copy link
Member

This looks good to me. but just checking. can we expose this somehow to the admin interface so we dont need to deploy the whole thing again and again

anantshri
anantshri approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@anantshri anantshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhisek
Copy link
Member Author

abhisek commented Dec 9, 2024

This looks good to me. but just checking. can we expose this somehow to the admin interface so we dont need to deploy the whole thing again and again

Lets see if we have frequent need to change this. We can build a DB / config backend for this announcement.

@abhisek abhisek merged commit 5426681 into master Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anantshri anantshri anantshri approved these changes

@prashant3535 prashant3535 Awaiting requested review from prashant3535

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhisek @anantshri