base_api.py: Implement operators and document them in cli help

Right now for operators we are using "magic" suffix such as __gt, __lt and so on, which is not documented and a bit non-intuitive. We can make cli tool more intuitive with this patch, where it will hide from user this magic, until we find better mechanism to handle operators as mentioned in kernelci/kernelci-api#356 Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat · Sep 18, 2023 · 9def0ed · 9def0ed
1 parent 77c16d9
commit 9def0ed
Showing 1 changed file with 21 additions and 4 deletions.
diff --git a/kernelci/cli/base_api.py b/kernelci/cli/base_api.py
@@ -12,6 +12,7 @@
 
 import abc
 import json
+import re
 
 import kernelci.api
 from .base import Command, Args, catch_http_error
@@ -63,12 +64,28 @@ class AttributesCommand(APICommand):
         {
             'name': 'attributes',
             'nargs': '*',
-            'help': "Attributes in name=value format",
+            'help': "Attributes in name=value format, where = is OPERATOR and can be one of: >, <, >=, <=, =",
         },
     ]
 
     @classmethod
     def _split_attributes(cls, attributes):
-        return dict(
-            tuple(attr.split('=')) for attr in attributes
-        ) if attributes else {}
+        rval = {}
+        for attribute in attributes:
+            pattern = r'^(\w+)([!=<>]+)(\w+)$'
+            match = re.match(pattern, attribute)
+            if match:
+                attribute, operator, value = match.groups()
+                # if operator is >= then append to attribute '__gte' suffix
+                # and so on
+                switch = {
+                    '>': '__gt',
+                    '<': '__lt',
+                    '>=': '__gte',
+                    '<=': '__lte',
+                }
+                if operator in switch:
+                    attribute += switch[operator]
+                rval[attribute] = value
+
+        return rval