Added LocalizationManager #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address #84
This PR integrates LocalizationManager in the NStack SDK, so LocalizationManager is not added as a subdependency, but as part of the SDK. This way, NStack will be a single library with no dependencies, making a lot easier to work with and integrate in other projects.
So far, LocalizationManager was a separate repo because there were projects that needed to only use it without NStack (so the language files were hosted on a separate server, the app was still using the same localization system, but without integrating NStack or making any API calls to the NStack backend). In order to avoid this problem, and in order not to end up having having to manually maintain 2 copies of the same source code for LocalizationManager (both in here and in the LocalizationManager repo), I'll try to expose LocalizationManager via NStack without the need to integrate NStack or call
NStack.start().This PR is still WIP, as I still need to do the following:
masterdoesn't have that yet, it's onfeature/spm-support)