add comment explaining metrics service annotations

nsqio · Oct 31, 2024 · a8f90d2 · a8f90d2
1 parent 68fe53a
commit a8f90d2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/charts/nsq/values.yaml b/charts/nsq/values.yaml
@@ -177,6 +177,10 @@ metrics:
 
   service:
     annotations:
+      # Prometheus does not connect to this service directly,
+      # instead it uses this port to connect to each target
+      # of the service (each nsqd).
+      # TODO: remove service and annotate pods instead?
       prometheus.io/scrape: "true"
       prometheus.io/port: "{{ .Values.metrics.containerPort }}"
       prometheus.io/path: "/metrics"