Skip to content

Commit

Permalink
Drop unused parameter.
Browse files Browse the repository at this point in the history
It is never called like that so I assume value is always None in practice.
  • Loading branch information
jmchilton authored and nsoranzo committed Aug 1, 2024
1 parent b0c1eaa commit bb1f00c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/galaxy/tools/parameters/basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -1668,9 +1668,9 @@ def recurse_option_elems(cur_options, option_elems):
elif not self.dynamic_options:
recurse_option_elems(self.options, elem.find("options").findall("option"))

def _get_options_from_code(self, trans=None, value=None, other_values=None):
def _get_options_from_code(self, trans=None, other_values=None):
assert self.dynamic_options, Exception("dynamic_options was not specifed")
call_other_values = ExpressionContext({"__trans__": trans, "__value__": value})
call_other_values = ExpressionContext({"__trans__": trans, "__value__": None})
if other_values:
call_other_values.parent = other_values.parent
call_other_values.update(other_values.dict)
Expand All @@ -1679,11 +1679,11 @@ def _get_options_from_code(self, trans=None, value=None, other_values=None):
except Exception:
return []

def get_options(self, trans=None, value=None, other_values=None):
def get_options(self, trans=None, other_values=None):
other_values = other_values or {}
if self.is_dynamic:
if self.dynamic_options:
options = self._get_options_from_code(trans=trans, value=value, other_values=other_values)
options = self._get_options_from_code(trans=trans, other_values=other_values)
else:
options = []
for filter_key, filter_value in self.filtered.items():
Expand Down

0 comments on commit bb1f00c

Please sign in to comment.