Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup KVO when view is deallocating #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup KVO when view is deallocating #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Pod/Classes/OAStackView+Hiding.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ - (void)addObserverForView:(UIView*)view {
}

- (void)removeObserverForView:(UIView*)view {
[view removeObserver:self forKeyPath:@"hidden"];
@try {
[view removeObserver:self forKeyPath:@"hidden"];
} @catch (NSException * e) {
NSLog(@"OAStackView: Unable to remove observer for view %@: %@", view, e);
}
}

- (void)addObserverForViews:(NSArray*)views {
Expand Down Expand Up @@ -63,4 +67,10 @@ - (void)willRemoveSubview:(UIView *)subview {
[self removeObserverForView:subview];
}

#pragma mark clean up

- (void)dealloc {
[self removeObserverForViews:self.subviews];
}

@end