-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CITATION.cff #154
Create CITATION.cff #154
Conversation
Note: added the badge to the README on the main branch already so that's why it is not in this PR. |
@rmarow could you move the badge to the top? See some other projects like QGreenland for examples of how badges are typically displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a few changes to ensure this file doesn't have to be manually managed every time we make a release! Otherwise, looks great, nice work :)
pyproject.toml
Outdated
parse = """ | ||
(?P<major>\\d+)\\.(?P<minor>\\d+)\\.(?P<patch>\\d+) | ||
(?: | ||
(?P<prerelease>alpha|beta|rc) | ||
(?P<build>\\d+) | ||
)? | ||
$ | ||
""" | ||
serialize = [ | ||
"{major}.{minor}.{patch}{prerelease}{build}", | ||
"{major}.{minor}.{patch}", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of the parse
and serialize
sections and just use the default behavior. We don't need to think about "alpha" or "beta" or "rc", at least not yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And can get rid of [tool.bumpversion.parts.prerelease]
and [tool.bumpversion.parts.build]
sections
Running into this while testing the new bump-my-version config. Haven't had much of a chance to look into it yet. |
You shouldn't need to pass both a "part" and a |
related to #151