Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invoke script using dev DB in non-dev #142

Merged
merged 39 commits into from
Sep 28, 2023
Merged

Fix invoke script using dev DB in non-dev #142

merged 39 commits into from
Sep 28, 2023

Conversation

rmarow
Copy link
Contributor

@rmarow rmarow commented Sep 15, 2023

No description provided.

@MattF-NSIDC MattF-NSIDC changed the title Non dev db issue Fix invoke script using dev DB in non-dev Sep 15, 2023
@rmarow
Copy link
Contributor Author

rmarow commented Sep 19, 2023

Issue: Login manager requires app as an argument.

@rmarow
Copy link
Contributor Author

rmarow commented Sep 19, 2023

nearly there

notes for tomorrow-- currently facing google access error, made sure the client_id and secret were correct - also I think we should be bypassing this login since I'm working in dev. this may be related to the change to @app.before_request in login.py
Screen Shot 2023-09-19 at 5 57 21 PM

Url map for reference

>>> app.url_map
Map([<Rule '/static/<filename>' (GET, HEAD, OPTIONS) -> static>,
 <Rule '/bootstrap/static/<filename>' (GET, HEAD, OPTIONS) -> bootstrap.static>,
 <Rule '/' (GET, HEAD, OPTIONS) -> root.root>,
 <Rule '/surveys' (GET, HEAD, OPTIONS) -> surveys.view_surveys>,
 <Rule '/new' (GET, POST, HEAD, OPTIONS) -> survey.new_survey>,
 <Rule '/<survey_id>' (GET, HEAD, OPTIONS) -> survey.view_survey>,
 <Rule '/users' (GET, HEAD, OPTIONS) -> users.view_users>,
 <Rule '/login' (GET, HEAD, OPTIONS) -> login.login>,
 <Rule '/google_oauth/google' (GET, HEAD, OPTIONS) -> google.login>,
 <Rule '/google_oauth/google/authorized' (GET, HEAD, OPTIONS) -> google.authorized>,
 <Rule '/response/<survey_id>' (GET, HEAD, OPTIONS) -> response.view_response>])

Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just needs a couple comment changes :)

docker-compose.dev.yml Show resolved Hide resolved
usaon_vta_survey/__init__.py Outdated Show resolved Hide resolved
usaon_vta_survey/routes/login.py Outdated Show resolved Hide resolved
usaon_vta_survey/routes/user.py Show resolved Hide resolved
@rmarow rmarow merged commit 46bc4ed into main Sep 28, 2023
2 checks passed
@rmarow rmarow deleted the non-dev-db-issue branch September 28, 2023 14:48
@@ -81,7 +85,11 @@ def before_request():
app.register_blueprint(login_bp)
app.register_blueprint(logout_bp)
app.register_blueprint(blueprint, url_prefix="/google_oauth")
app.register_blueprint(response.bp)
app.register_blueprint(bp)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmarow bp here is hard to read. What about response_bp?

I feel obs_bp and dp_bp would also be more readable spelling out the words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants