Update for params unification #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isort` doesn't seem to be working as expected, not sure what's up. TODO!
|
Currently just failing because the version of |
sc0tts
reviewed
Oct 13, 2023
| @@ -323,7 +320,7 @@ def compute_initial_daily_ecdr_dataset( | |||
| ) | |||
| logger.info("Initialized spatial_interpolation_flag with TB fill locations") | |||
|
|
|||
| bt_coefs_init = pmi_bt_params.get_bootstrap_params( | |||
| bt_coefs_init = pmi_bt_params.get_ausi_bootstrap_params( | |||
There was a problem hiding this comment.
Eventually, I think we want to have a high-level "prepare_bootstrap_calcuation()" or similar which would include the necessary instructions for determining both the bootstrap parameters -- including dynamic or date-dependent values -- as well as the exact fields that will be used in the algorithm calculation.
The renaming of the function here is a good start toward that goal.
sc0tts
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects changes in nsidc/pm_icecon#24