Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly NRT #168

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Monthly NRT #168

merged 8 commits into from
Sep 30, 2024

Conversation

trey-stafford
Copy link
Contributor

Adds a CLI for monthly NRT processing.

This may belong better in the VM repo, where specifics about how the environment
are setup could be included...
@trey-stafford trey-stafford marked this pull request as ready for review September 27, 2024 20:42
@trey-stafford
Copy link
Contributor Author

This does not update any attrs to reflect the NRT nature of this product. Need to update the title/version/summary/metadata_link attrs similar to how the daily nrt code does it.

daily-nrt --last-n-days 5 --hemisphere both
```

Note that the `--overwrite` flag can be used to re-create NRT data if e.g., a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to explicitly give the command to use the overwrite flag?

eg

daily-nrt --last-n-days 5 --hemisphere both --overwrite

...in this README.md ?

Copy link
Contributor

@sc0tts sc0tts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, always good to see the single-use kwarg is_nrt go away.

And good to see the NRT output file directory structure mirror that of the "final" processing.

Improves readability. Originally thought I'd break this down so that I could
separately create a monthly ds so that the monthly nrt cli could override global
attrs. But this code is already nrt-aware (`is_nrt`) and so can handle the
overrides itself.
This ensures if we decide to change the NRT platform id later, that we update
the summary.
Override G10016-specific attrs in monthly NRT files
@trey-stafford trey-stafford merged commit 37d8da4 into ecdr-at-25km Sep 30, 2024
1 check passed
@trey-stafford trey-stafford deleted the monthly-nrt branch September 30, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants