Rename flag vars to include _flag at the end
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trey-stafford
changed the title
_flag at the end
sc0tts
reviewed
Sep 19, 2024
| @@ -104,7 +104,6 @@ def prepare_monthly_nc_for_publication( | |||
| if f"_{PROTOTYPE_PLATFORM_ID}_" not in fp.name | |||
| ] | |||
| if len(default_monthly_fps) != 1: | |||
| breakpoint() | |||
There was a problem hiding this comment.
Lol. This reminds of the type of thing I submit to the repo!
There was a problem hiding this comment.
It happens 😅 . Ideally our linter would identify these and flag them for removal. I wonder if that's something we can enable. Might look at later.
sc0tts
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.