Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup duplicate CDR logic from pm_icecon #10

Merged
merged 17 commits into from
Oct 19, 2023

Conversation

trey-stafford
Copy link
Contributor

@trey-stafford trey-stafford commented Oct 18, 2023

Title.

Also updates the dev documentation, removes other OBE elements, and does some minor reorg.

Confirmed that the CLI works to generate sample idecdr data file.

@trey-stafford trey-stafford requested a review from sc0tts October 18, 2023 20:20
@trey-stafford trey-stafford marked this pull request as ready for review October 18, 2023 20:20
```
$ mypy
```
See [doc/development.md](doc/development.md) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling this information into a sub-document is a great idea!

Copy link
Contributor

@sc0tts sc0tts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a much needed set of refactorings and clarifications for this code.

@trey-stafford trey-stafford merged commit 9dcb667 into main Oct 19, 2023
1 check passed
@trey-stafford trey-stafford deleted the cleanup-cdr-logic-from-pmicecon branch October 19, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants