Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust typing for nt param functions expecting a ValidSatellite. #40

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Adjust typing for nt param functions expecting a ValidSatellite. #40

merged 1 commit into from
Jan 25, 2024

Conversation

trey-stafford
Copy link
Contributor

@trey-stafford trey-stafford commented Jan 25, 2024 •
edited
Loading

Associated seaice_ecdr PR: nsidc/seaice_ecdr#81

@trey-stafford
Adjust typing for nt param functions expecting a ValidSatellite.
05de629 
Not ideal...ValidSatellite was meant to ensure that the correct params were used
for the right platform/provider combo. This is confusing!
@trey-stafford trey-stafford mentioned this pull request Jan 25, 2024
Merged
@trey-stafford
Copy link
Contributor Author

TODO: release v0.3.0 of pm_tb_data. That's what is causing the CI errors.

@trey-stafford trey-stafford marked this pull request as ready for review January 25, 2024 18:49
@trey-stafford trey-stafford merged commit 7750697 into add_f17_bt_params Jan 25, 2024
1 check failed
@trey-stafford trey-stafford deleted the add_f17_bt_params_trey branch January 25, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trey-stafford