Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reorg of pm_tb_data AMSR-related fetch code. #38

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Support reorg of pm_tb_data AMSR-related fetch code. #38

merged 1 commit into from
Jan 10, 2024

Conversation

trey-stafford
Copy link
Contributor

@trey-stafford trey-stafford commented Jan 9, 2024 •
edited
Loading

Associated PR: nsidc/pm_tb_data#18

Tests should pass once ^ is merged.

@trey-stafford trey-stafford mentioned this pull request Jan 9, 2024
Merged
@trey-stafford trey-stafford requested a review from sc0tts January 9, 2024 17:49
sc0tts
sc0tts approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@sc0tts sc0tts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we will probably need to generalize the entire process of getting resolutions -- eg, the valid AMSR_RESOLUTIONS will differ between these AMSA/ based files and (say) NSIDC-0630 -- but this is a good interim step in the right direction.

@trey-stafford trey-stafford marked this pull request as ready for review January 10, 2024 16:51
@trey-stafford trey-stafford merged commit b8ca804 into main Jan 10, 2024
1 check failed
@trey-stafford trey-stafford deleted the support-reorg-pmtbdata branch January 10, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0tts sc0tts sc0tts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trey-stafford @sc0tts