Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup vestigial GH Actions YAML for documentation #324

Closed
wants to merge 1 commit into from
Closed

Cleanup vestigial GH Actions YAML for documentation #324

wants to merge 1 commit into from

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Oct 21, 2023 •
edited
Loading

See #274 for more

@github-actions
Copy link

github-actions bot commented Oct 21, 2023 •
edited
Loading

Binder 👈 Launch a binder notebook on this branch for commit 2ef3f97

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 9aaf12d

@mfisher87 mfisher87 mentioned this pull request Oct 21, 2023
Closed
jrbourbeau
jrbourbeau reviewed Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm curious if we need this workflow at all anymore? Maybe we just stick with readthedocs for all documentation builds?

@mfisher87 mfisher87 force-pushed the cleanup-docs-action branch from 2ef3f97 to 9aaf12d Compare October 21, 2023 00:43
@mfisher87
Copy link
Collaborator Author

mfisher87 commented Oct 21, 2023 •
edited
Loading

Normally I'd say let's put it all in one place, but in this case I'm not sure. We've already shared out links to the earthaccess documentation. @betolink @asteiker thoughts? EDIT: Can we discuss in #277 ?

@mfisher87 mfisher87 changed the title WIP cleanup vestigial GH Actions YAML for documentation Cleanup vestigial GH Actions YAML for documentation Oct 21, 2023
@mfisher87 mfisher87 marked this pull request as ready for review October 21, 2023 00:58
@mfisher87 mfisher87 mentioned this pull request Oct 21, 2023
Closed
@jrbourbeau jrbourbeau mentioned this pull request Oct 23, 2023
Closed
betolink
betolink reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@betolink betolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this correctly, we are not deploying the documentation for PRs?

@mfisher87
Copy link
Collaborator Author

ReadTheDocs is deploying docs for PRs. If you click "Show all checks" for this PR you can see the successful build. We didn't need PR previews on both RTD and GitHub Pages, so the original intent of this PR was to remove the redundancy.

Now that we've decided that GH Pages will redirect to RTD, we no longer need this PR.

@mfisher87 mfisher87 closed this Nov 22, 2023
@mfisher87 mfisher87 deleted the cleanup-docs-action branch November 22, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

@betolink betolink betolink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfisher87 @betolink @jrbourbeau