Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if stream audio/video in FFmpeg_Transcoder::can_copy_stream #152

Merged
merged 2 commits into from
Dec 20, 2023
Merged

check if stream audio/video in FFmpeg_Transcoder::can_copy_stream #152

merged 2 commits into from
Dec 20, 2023

Conversation

mihaiush
Copy link

fixes #151

@nschlia
Copy link
Owner

nschlia commented Dec 19, 2023

The pull request does not build with clang because of this line:

 ffmpeg_transcoder.cc:836:18: note: in instantiation of function template specialization 'Logging::debug<const char *, std::basic_string<char> &, const char *, const char *>' requested here
Logging::debug(virtname(), "Check autocopy strict: %1: %2 -> %3", codec_type_str, avcodec_get_name(codec_in), avcodec_get_name(codec_out));

Please change it to:

 Logging::debug(virtname(), "Check autocopy strict: %1: %2 -> %3", codec_type_str.c_str(), avcodec_get_name(codec_in), avcodec_get_name(codec_out));

Basically you need to change codec_type_str to codec_type_str.c_str().
clang does not allow objects to be passed as varargs (C++ actually does not, this is a GNU extension).

@nschlia nschlia merged commit 705aef3 into nschlia:master Dec 20, 2023
8 checks passed
@nschlia
Copy link
Owner

nschlia commented Dec 20, 2023

@mihaiush Pull request accepted, thanks for the bug report & the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocopy STRICT never triggers for video streams
2 participants