Undo unnecessary changes

nsarka · Jul 9, 2024 · 4e61412 · 4e61412
1 parent 0a72a73
commit 4e61412
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/core/ucc_coll.c b/src/core/ucc_coll.c
@@ -178,8 +178,6 @@ UCC_CORE_PROFILE_FUNC(ucc_status_t, ucc_collective_init,
     ucc_ee_type_t             coll_ee_type;
     size_t                    coll_size;
 
-    printf("nick in ucc_collective_init: dst buffer=%p\n", coll_args->dst.info.buffer);
-
     if (ucc_unlikely(team->state != UCC_TEAM_ACTIVE)) {
         ucc_error("team %p is used before team create is completed", team);
         return UCC_ERR_INVALID_PARAM;
@@ -250,11 +248,10 @@ UCC_CORE_PROFILE_FUNC(ucc_status_t, ucc_collective_init,
         goto free_scratch;
     }
 
-    coll_mem_type = ucc_coll_args_mem_type(&op_args.args, team->rank);
-
     task->flags |= UCC_COLL_TASK_FLAG_TOP_LEVEL;
     if (task->flags & UCC_COLL_TASK_FLAG_EXECUTOR) {
         task->flags |= UCC_COLL_TASK_FLAG_EXECUTOR_STOP;
+        coll_mem_type = ucc_coll_args_mem_type(&op_args.args, team->rank);
         switch(coll_mem_type) {
         case UCC_MEMORY_TYPE_CUDA:
         case UCC_MEMORY_TYPE_CUDA_MANAGED:

diff --git a/src/utils/ucc_coll_utils.c b/src/utils/ucc_coll_utils.c
@@ -290,8 +290,8 @@ ucc_memory_type_t ucc_coll_args_mem_type(const ucc_coll_args_t *args,
         return UCC_MEMORY_TYPE_NOT_APPLY;
     case UCC_COLL_TYPE_BCAST:
         return args->src.info.mem_type;
-    case UCC_COLL_TYPE_ALLREDUCE:
     case UCC_COLL_TYPE_ALLTOALL:
+    case UCC_COLL_TYPE_ALLREDUCE:
     case UCC_COLL_TYPE_ALLGATHER:
     case UCC_COLL_TYPE_REDUCE_SCATTER:
         return args->dst.info.mem_type;