feat: add prettier packages #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and configure them in eslint config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank You for this awesome project - it really speeds things up for me.
I noticed the prettier rules were not applied: the generated project assumes that prettier has been installed in VSCode as an extension and set up correctly.
I think this might work for some people, for me - it didn't and I have no idea why to be completely honest.
I was able to get things working by adding "eslint-config-prettier", "eslint-plugin-prettier" and "prettier" itself to my aoc workspace, confed them in eslint.config.js and got it working.
In theory, the explicitly installed prettier packages should work out of the box for most people.
Made the same changes to the generator, but I have no way of validating whether this works, though - I wasnt able to use the locally built generator, it'll always use the one published in npm 🤷