feat(js): update vue/node app and lib generators to support TS solutions #29299
+2,459
−314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2e32362. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following target is in progress ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/vue-node-generators
branch
11 times, most recently
from
2698fdb to
a2521e4
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
074479a to
7d89b62
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
13 times, most recently
from
3bfea15 to
24c6ea1
Compare
jaysoo
requested review from
a team,
Coly010,
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
jaysoo
force-pushed
the
feat/vue-node-generators
branch
2 times, most recently
from
db02003 to
9cd4dc2
Compare
jaysoo
commented
Dec 11, 2024
| @@ -97,7 +97,12 @@ export async function configurationGeneratorInternal( | |||
| if (isTsSolutionSetup) { | |||
| // skip eslint from typechecking since it extends from root file that is outside rootDir | |||
| if (options.linter === 'eslint') { | |||
| tsconfig.exclude = ['dist', 'eslint.config.js']; | |||
| tsconfig.exclude = [ | |||
There was a problem hiding this comment.
I realized that PW didn't exclude the same files as our other generators, so this updates them. It'll also help once we rename eslint.config.js to eslint.config.cjs to resolve CJS/ESM issues.
jaysoo
changed the title
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
9cd4dc2 to
514d742
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
514d742 to
a8b05a6
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
3 times, most recently
from
cfa26af to
603091e
Compare
Coly010
approved these changes
Dec 12, 2024
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
603091e to
2e32362
Compare
jaysoo
commented
Dec 12, 2024
| @@ -0,0 +1,5 @@ | |||
| declare module '*.vue' { | |||
There was a problem hiding this comment.
This is needed because typecheck never worked without Volar in VSCode. The shims here at least makes it pass even though nothing meaningful is checked. We already do the same for Vue libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #