Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(core): migrate to picospinner #29138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Dec 2, 2024

Migrates from ora to picospinner, a much lighter package.

this should roughly be a drop in replacement and will be faster/lighter. it is maintained by the tinylibs org

Migrates from `ora` to `picospinner`, a much lighter package.
@43081j 43081j requested a review from a team as a code owner December 2, 2024 01:41
@43081j 43081j requested a review from Cammisuli December 2, 2024 01:41
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 1:44am

Copy link

nx-cloud bot commented Dec 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 53fa439. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx documentation --no-dte

Sent with 💌 from NxCloud.

@JamesHenry
Copy link
Collaborator

@43081j I was thinking we would go for nanospinner for this, but found an issue that I linked to from the umbrella cleanup issue: es-tooling/ecosystem-cleanup#117 (comment)

Please could you confirm this library does not have this issue? (Should be able to modify the linked stackblitz) and how the two libraries compare?

@43081j
Copy link
Contributor Author

43081j commented Dec 3, 2024

I'll take a look when I can 👍

The two libraries are pretty well aligned, so it comes mostly down to personal preference. picospinner is a bit more customisable

Both maintainers are active in our community too, so you really could just flip a coin here 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants