Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): use prepatch version for pre-release dependent package updates #29123

Conversation

fabioatcorreia
Copy link
Contributor

Current Behavior

When creating a pre-release version, if a package only had its dependencies updated, it creates a new patch version.

nx release version --preid=alpha

UPDATE packages/XXX/package.json [dry-run]

    "name": "XXX",
-   "version": "7.2.0",
+   "version": "7.2.1",

    "dependencies": {
-     "YYY": "16.0.0",
+     "YYY": "16.1.0-alpha.0",
      "react": "18.2.0",

Expected Behavior

When creating a pre-release version, if a package only had its dependencies updated, it creates a new prepatch version.

UPDATE packages/XXX/package.json [dry-run]

    "name": "XXX",
-   "version": "7.2.0",
+   "version": "7.2.1-alpha.0",

    "dependencies": {
-     "YYY": "16.0.0",
+     "YYY": "16.1.0-alpha.0",
      "react": "18.2.0",

Related Issue(s)

Couldn't find any

@fabioatcorreia fabioatcorreia requested a review from a team as a code owner November 29, 2024 17:59
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 3:54pm

@fabioatcorreia fabioatcorreia force-pushed the fix/pre-release-dependents-bump-version branch from e0dc755 to 97132a7 Compare December 2, 2024 09:48
@fabioatcorreia fabioatcorreia force-pushed the fix/pre-release-dependents-bump-version branch from 97132a7 to c175804 Compare December 5, 2024 15:51
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabioatcorreia!

@JamesHenry JamesHenry merged commit 3474d7c into nrwl:master Dec 9, 2024
6 checks passed
@fabioatcorreia fabioatcorreia deleted the fix/pre-release-dependents-bump-version branch December 9, 2024 14:02
FrozenPandaz pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants