Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cache): fix base_branch input schema #64

Closed
wants to merge 2 commits into from

Conversation

puku0x
Copy link

@puku0x puku0x commented Aug 6, 2024

This PR fixes typo about base_brunch.

nrwl/nx#27230
nrwl/nx#27179

@rarmatei
Copy link
Contributor

rarmatei commented Aug 14, 2024

hey! thank you so much for this! I had already fixed it as part of this to allow both inputs: 62e06f3#diff-608171f3e1aabf2c74586df6004cfa2c834e9a456ed688df09f744ab86332f44R5994

I think base-branch (with dashes) makes more sense anyway (how it was initially), as we use the same scheme for some of the other properties in agents.yaml

@puku0x
Copy link
Author

puku0x commented Aug 15, 2024

Closing PR in favor of #63

@puku0x puku0x closed this Aug 15, 2024
@puku0x puku0x deleted the docs-fix-base-branch branch August 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants