generate a single caching hash #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarmatei
commented
Jul 30, 2024
| if (hashCollections.length > 1) { | ||
| return hash(hashCollections.join(' | ')); | ||
| } | ||
| return hashCollections.join(' | '); |
There was a problem hiding this comment.
I could've just always returned
return hash(hashCollections.join(' | '));but I kept the old way of hashing when it's a single-key for backward compatibility purposes - so we don't bust everyone's cache when this gets merged in
There was a problem hiding this comment.
I'd leave that in a comment in the code?
lourw
reviewed
Jul 30, 2024
lourw
reviewed
Jul 30, 2024
lourw
approved these changes
Jul 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* generate a single caching hash * add backwards compatibility * print out key info * add cache step test setup * add cache step test setup * add tests for caching step * build source files * improve messaging * commit changed source files * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/nxdev/issue/INF-1095/agents-workflows-will-fail-if-more-than-one-package-lockyarnlock