Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test coverage non strict object into mosTime #98

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Mar 18, 2024

About the Contributor

On behalf of BBC

Type of Contribution

This is a: Test Coverage

Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)

Current Behavior

A non strict mosTime that parsed an object was not tested

New Behavior

Added specific test for parsing object to non strict mosTime

Testing Instructions

Other Information

Status

  • [x ] PR is ready to be reviewed.
  • [ x] The functionality has been tested by the author.
  • [ x] Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin self-requested a review March 18, 2024 08:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (9bb6825) to head (994c263).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   77.43%   77.53%   +0.10%     
==========================================
  Files          65       65              
  Lines        3572     3593      +21     
  Branches      823      813      -10     
==========================================
+ Hits         2766     2786      +20     
- Misses        747      807      +60     
+ Partials       59        0      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl changed the title Test coverage non strict object into mosTime chore: Test coverage non strict object into mosTime Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants