Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing OpenDrain[IO] tests #402

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Add missing OpenDrain[IO] tests #402

merged 1 commit into from
Sep 28, 2022

Conversation

Finomnis
Copy link
Contributor

@Finomnis Finomnis mentioned this pull request Sep 28, 2022
Merged
@Finomnis Finomnis force-pushed the add_missing_open_drain_tests branch from 9af1dad to 314d980 Compare September 28, 2022 12:10
@jonas-schievink
Copy link
Contributor

Thanks! Note that we don't run these tests during CI, so updating them for HAL changes isn't necessary.

bors r+

@Finomnis
Copy link
Contributor Author

Thanks! Note that we don't run these tests during CI, so updating them for HAL changes isn't necessary.

bors r+

It's good practice, though ;)

@bors
Copy link
Contributor

bors bot commented Sep 28, 2022

Build succeeded:

@bors bors bot merged commit 917d984 into nrf-rs:master Sep 28, 2022
@Finomnis Finomnis deleted the add_missing_open_drain_tests branch September 29, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Finomnis @jonas-schievink