Bump matrix tests to oldest and newest Python versions currently supported in CI #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still support Python 3.6, and probably older ones too, but it's no longer available in the ubuntu-latest image on GitHub Actions. So instead of 3.6 and 3.9, let's matrix test the oldest and newest Python versions we can at the moment, i.e., 3.7 and 3.12.
|
PortageClusterUtils will also need its actions versions bumped, like in 3f89b04 |
SamuelLarkin
approved these changes
Apr 3, 2024
| @@ -8,15 +8,15 @@ jobs: | |||
| strategy: | |||
| max-parallel: 5 | |||
| matrix: | |||
| python: [3.6, 3.9] | |||
| python: ["3.7", "3.12"] | |||
There was a problem hiding this comment.
Don't we want to test 3.7, 3.8, 3.9, 3.10, 3.11 & 3.12?
There was a problem hiding this comment.
We could, but it didn't seem necessary. It's not like we have complex Python stuff in there, it's mostly Perl and others anyway. It didn't seem worth the cycles.
There was a problem hiding this comment.
For the environment 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.