feat(api-service): refactor issue error messages #7359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…messages # Conflicts: # apps/api/src/app/workflows-v2/shared/schemas/chat-control.schema.ts # apps/api/src/app/workflows-v2/shared/schemas/delay-control.schema.ts # apps/api/src/app/workflows-v2/shared/schemas/digest-control.schema.ts # apps/api/src/app/workflows-v2/shared/schemas/email-control.schema.ts # apps/api/src/app/workflows-v2/shared/schemas/in-app-control.schema.ts # apps/api/src/app/workflows-v2/shared/schemas/push-control.schema.ts # apps/api/src/app/workflows-v2/shared/schemas/sms-control.schema.ts
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
djabarovgeorge
changed the title
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
…messages # Conflicts: # apps/api/src/app/inbox/usecases/get-inbox-preferences/get-inbox-preferences.spec.ts
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
apps/api/src/app/environments-v1/usecases/output-renderers/digest-output-renderer.usecase.ts
Show resolved
Hide resolved
|
|
||
| if (isEmpty(body)) { | ||
| return { subject, body: '' }; | ||
| if (!body || typeof body !== 'string') { |
There was a problem hiding this comment.
Nit picky comment: Since tip tap processing takes place if the body exists, it is more readable to change the logic to
let renderedBody = '';
const expandedMailyContent = this.transformMailyDynamicBlocks(body, renderCommand.fullPayloadForRender);
const parsedTipTap = await this.parseTipTapNodeByLiquid(expandedMailyContent, renderCommand);
renderedBody = await this.renderEmail(parsedTipTap);
}
return { subject, renderedBody }
apps/api/src/app/workflows-v2/usecases/generate-preview/generate-preview.usecase.ts
Show resolved
Hide resolved
| ): Record<string, unknown> { | ||
| const outputSchema = channelStepSchemas[type].output || actionStepSchemas[type].output; | ||
|
|
||
| if (!outputSchema || !controlValues) { |
There was a problem hiding this comment.
We should throw an error at this point. The inability to identify an outputSchema from the framework indicates an invalid workflow definition.
There was a problem hiding this comment.
agreed, but I tried to handle it as gracefully as possible. maybe we could log and return the controlValues instead? are you sure we need to throw an error here?
There was a problem hiding this comment.
Yes. Without output schema, there is no step. So we need to fail fast.
apps/api/src/app/workflows-v2/usecases/upsert-workflow/upsert-workflow.usecase.ts
Show resolved
Hide resolved
| @@ -0,0 +1,7 @@ | |||
| export * from './in-app-control.schema'; | |||
There was a problem hiding this comment.
These schemas are strictly connected to the built-in Dashboard UI powered by the new Novu workflow V2 API. Do they belong in the application generic? I don't feel strongly about it, but I'd consider it a code smell if these schemas were reused in other services.
There was a problem hiding this comment.
Interesting and valid point, i can share why they are in app-gen.
The are in app-gen because i reused the types from the schema in the dashboardSanitizeControlValues function so i needed them close to it, and dashboardSanitizeControlValues is used in Worker.
Let me know what you think about such an implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
https://www.loom.com/share/91f0b186dea3470f987ff902ff9b8933
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer