fix(dashboard): Tweak arbitrary variable handling #7351
Conversation
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| properties: {}, | ||
| additionalProperties: true, | ||
| }; | ||
| return emptyJsonSchema(); |
| label: null, | ||
| fallback: null, | ||
| showIfKey: null, | ||
| required: false, |
There was a problem hiding this comment.
question: What the required prop controls here?
There was a problem hiding this comment.
The
There was a problem hiding this comment.
But does is solve the actual problem then? Because the issue was happening when maily autocomplete returned "empty results" instead of allowing to add a new variable from the dropdown
There was a problem hiding this comment.
A database migration solves the issue. I was torn between teaching the code to handle invalid payload vs just correcting the DB value and I did the latter as for code-first any user-defined payload schema should be accepted.
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
changed the title
What changed? Why was the change needed?