feat(dashboard): digest aggregated by key field editor with autosuggestions #7322
Conversation
There was a problem hiding this comment.
Nice 👌🏼
Not a blocker: We may need to add a custom scrollbar for the editor. the current one looks a bit clunky 😅
|
@LetItRock do we need to have the {{curly}} braces for it in the design? I was expecting not to have it and select the key itself. I'm concerned it's confusing and people won't understand the {{ are needed. cc. @twentyone24 |
| className={cn( | ||
| 'min-w-[20ch] [appearance:textfield] [&::-webkit-inner-spin-button]:appearance-none [&::-webkit-outer-spin-button]:appearance-none' | ||
| )} | ||
| <Editor |
There was a problem hiding this comment.
Note that as part of future work, we need to introduce a single line editor component that leverages the <Editor/> but behaves like an input. That is, on Enter press no new limes should be added, and on tab press we should move to the next input in the form instead of applying indentation to the current line of text.
@scopsy This is our approach in "almost" all editor fields; the field is free text plus variables. I know this one is a bit different, but I don't remember if we allow having multiple keys separated by a comma (like we had in v1) |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What changed? Why was the change needed?
Digest - aggregated by key field support the editor with autosuggestions for the variables.
Screenshots
Screen.Recording.2024-12-18.at.12.15.04.mov